Skip to content

Conversation

zuoyaofu
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Users should be able to select a specific bedrock model for agentic chat.

Adds a dropdown with 3 options: auto, sonnet 3.7 and sonnet 3.5, the selected value gets passed to the model request.

Flare changes: aws/language-servers#1294

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zuoyaofu zuoyaofu changed the title feat: Add model selection for agentic chat feat(amazonq): Add model selection for agentic chat May 30, 2025
@zuoyaofu zuoyaofu marked this pull request as ready for review May 30, 2025 23:54
@zuoyaofu zuoyaofu requested review from a team as code owners May 30, 2025 23:54
Copy link
Contributor

@rli rli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hold for release approval

cancelButtonWhenLoading: false,
})
} else {
this.mynahUI?.updateStore(affectedTabId, { promptInputOptions: [] })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was to address the issue of "Inconsistent behavior when opening agent tabs (/review, /doc, etc)." When the tab is reused it keeps the prompt input options visible, but when a new tab is created it doesn't.

aws/aws-toolkit-vscode#7265

@zuoyaofu zuoyaofu changed the base branch from feature/q-lsp-chat to main June 14, 2025 01:54
@zuoyaofu zuoyaofu changed the base branch from main to feature/q-lsp-chat June 16, 2025 08:14
@zuoyaofu zuoyaofu changed the base branch from feature/q-lsp-chat to main June 16, 2025 17:50
@rli rli merged commit b56813a into aws:main Jun 16, 2025
11 of 12 checks passed
@zuoyaofu zuoyaofu deleted the model-selection branch June 27, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants